Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sigterm to the signal handler for Benchmark #1095

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Jul 9, 2024

Description

I added the handler for SIGTERM to the benchmark CL.
I tried with kill -TERM pid and it seems to work
I made the info message more pedantic.

@GiovanniBussi I added the handler correctly or should I add another function?

Target release

I would like my code to appear in release XXXXX

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@Iximiel
Copy link
Member Author

Iximiel commented Jul 9, 2024

The motivation is that on an HPC queue the signal sent on "time expired" usually is SIGTERM and as now the benchmark exit gracefully only with SIGINT

@GiovanniBussi GiovanniBussi merged commit 7401ac8 into plumed:master Jul 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants