Plumed h for gromacs #1105
Merged
Plumed h for gromacs #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iximiel
commented
Aug 7, 2024
Comment on lines
2348
to
+2349
| this->msg[0]='\0'; | ||
| __PLUMED_WRAPPER_STD strncat(this->msg,msg,__PLUMED_WRAPPER_CXX_EXCEPTION_BUFFER-1); | ||
| __PLUMED_WRAPPER_STD strncpy(this->msg,msg,__PLUMED_WRAPPER_CXX_EXCEPTION_BUFFER); |
There was a problem hiding this comment.
since this starts with this->msg[0]='\0';, I think that, only in this case, strncpy should work exactly like strncat
removing the "-1" ensures that the warning is gone
Iximiel
commented
Aug 7, 2024
src/wrapper/Plumed.h
Outdated
| @@ -3831,7 +3831,7 @@ void* plumed_attempt_dlopen(const char*path,int mode) { | |||
| __PLUMED_FPRINTF(stderr,"+++ Allocation error +++\n"); | |||
| __PLUMED_WRAPPER_STD abort(); | |||
| } | |||
| __PLUMED_WRAPPER_STD strncpy(pathcopy,path,strlenpath+1); | |||
| __PLUMED_WRAPPER_STD strcpy(pathcopy,path); | |||
There was a problem hiding this comment.
The ideal would be strdup, but it is not ansi C (actually is c23, from my understanding)
the +1 on the length with strncpy activates the warning about an overflow
by reading the manual strcpy copies the whole string plus the \0.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@Iximiel isn't this ready for merging? maybe it should target v2.10 |
|
It should aim 2.10, that was 'master' at time of setting this up, I am changing it Before readying this for merging it I was waiting for some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to add a plumed module to gromacs I got a few
-Wstringop-truncationwarningswith this PR I am trying to address them in a way that does not imply too many changes in the original plumed codebase.
I am starting this as a draft because likely this branch will get some more commit
the changes in the tests are to make the compiler complain about the tested code and not the code of the test.
Target release
I would like my code to appear in release 2.10
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests