Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler class does not have a watch field #1122

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Oct 7, 2024

Description

Remove extraneous field assignment. This breaks the build for me when trying to compile the master branch using https://github.com/plumed/conda/.

Since this was not caught in the 6 months since this code was introduced, maybe it is not used anywhere in the code base? I'm not sure why this is failing now.

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@GiovanniBussi
Copy link
Member

Yes I think it's not used. Actually I think it should be:

handler.section=nullptr;

Can you confirm that this would compile correctly? Thanks!

@Luthaf
Copy link
Contributor Author

Luthaf commented Oct 7, 2024

Yes, this builds correctly with section!

@GiovanniBussi GiovanniBussi merged commit 0f8e18f into plumed:master Oct 8, 2024
18 of 22 checks passed
@Luthaf Luthaf deleted the fix-tools branch October 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants