Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage secondarystructure/AntibetaRMSD #1125

Merged

Conversation

Mertcan-Puncist
Copy link
Contributor

@Mertcan-Puncist Mertcan-Puncist commented Oct 9, 2024

Description

this pull request focuses on enhancing the coverage test result for the secondarystructure/AntibetaRMSD.cpp

1- secondarystructure/AntibetaRMSD

i coppyed this original test

  • regtest/secondarystructure/rt33

modified and name it

  • secondarystructure/AntibetaRMSD

to cover:

  • secondarystructure/AntibetaRMSD.cpp

covered secondarystructure/AntibetaRMSD.cpp lines|

 119           0 :   } else if( style=="intra") {

2- regtest/secondarystructure/rt-coverage-parabetarmsd-parabeta-intra

i coppyed this original test

  • regtest/secondarystructure/rt33

modified and name it

  • rt-coverage-parabetarmsd-parabeta-intra

to cover:

  • secondarystructure/ParabetaRMSD.cpp

covered secondarystructure/ParabetaRMSD.cpp lines|

 120           0 :   } else if( style=="intra") {
 121             :     intra_chain=true; inter_chain=false;

3- regtest/secondarystructure/rt-coverage-parabetarmsd-parabeta

i coppyed this original test

  • regtest/secondarystructure/rt33

modified and name it

  • rt-coverage-parabetarmsd-parabeta

to cover:

  • secondarystructure/ParabetaRMSD.cpp

covered secondarystructure/ParabetaRMSD.cpplines|

 118           0 :   } else if( style=="inter") {
 119             :     intra_chain=false; inter_chain=true;
Target release

I would like my code to appear in release _v2.9

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@Mertcan-Puncist Mertcan-Puncist changed the base branch from master to v2.9 October 9, 2024 13:35
@Mertcan-Puncist Mertcan-Puncist force-pushed the improve-coverage-secondarystructure branch from 5e17c8c to 34309e7 Compare October 9, 2024 13:42
@carlocamilloni
Copy link
Member

Is this still in progress @Mertcan-Puncist ?

@Mertcan-Puncist Mertcan-Puncist marked this pull request as ready for review October 18, 2024 07:51
@Mertcan-Puncist
Copy link
Contributor Author

Mertcan-Puncist commented Oct 18, 2024

Is this still in progress @Mertcan-Puncist i

this one just for the testing the pull request .i have to add comment lines to be clear . thanks for letting me know .

@Mertcan-Puncist
Copy link
Contributor Author

Is this still in progress @Mertcan-Puncist ?

its ready to go . please take a look at it

@carlocamilloni
Copy link
Member

@Mertcan-Puncist I see that you are also covering for PARABETA here, is this covering features that are not covered in the other parabeta test? other reasons?

@Mertcan-Puncist
Copy link
Contributor Author

Mertcan-Puncist commented Oct 18, 2024

@Mertcan-Puncist I see that you are also covering for PARABETA here, is this covering features that are not covered in the other parabeta test? other reasons?

i am not covering for PARABETA in this 1 test. this test just copy of original regtest file name regtest/secondarystructure/rt33 . this original test has some lines about PARABETA but i didnt made any changes in that parts . thats why this is has no business with PARABETA .

i just modified lines that includes ANTIBETARMSD . so its just covers secondarystructure/AntibetaRMSD.cpp

Since you're asking this, I have 2 tests that covers some lines in secondarystructure/ParabetaRMSD, I'll add them in this branch right away

@Mertcan-Puncist
Copy link
Contributor Author

tests and explanations are ready for review

@carlocamilloni carlocamilloni merged commit 36ee031 into plumed:v2.9 Oct 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants