C++17 #953
C++17 #953
Conversation
Centos7 build not supported. Other tests are ok.
std::make_unique is available in C++14, so can be used now
# Conflicts: # configure # configure.ac
|
And, there is a massive change now from |
This reverts commit 766692d with some fixes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 85.11% 85.02% -0.09%
==========================================
Files 601 601
Lines 55609 55309 -300
==========================================
- Hits 47331 47028 -303
- Misses 8278 8281 +3
☔ View full report in Codecov by Sentry. |
|
Given the problems we have in #967 , I am more and more tempted to merge this and remove support for centos7. If there are no objections, I will merge within tomorrow. |
Description
I think that in the future it will become more and more difficult to maintain the CI tests on centos7 as packages we depend on for testing are less and less supported (see this recent fix 762bca7). I would suggest we do the transition now and switch to C++17 in plumed 2.10.
Closes #930 .
NB: I have to take care of the conflicts now, should be easy.
Target release
I would like my code to appear in release v2.10