Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated python version requested from the ci (v2.9) #968

Closed
wants to merge 14 commits into from

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Aug 2, 2023

Description

See #967, merged the modifications due to the EOL of python3.7

Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (442a33a) 85.12% compared to head (bdb0888) 85.12%.

❗ Current head bdb0888 differs from pull request most recent head afdb782. Consider uploading reports for the commit afdb782 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.9     #968   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         600      600           
  Lines       55555    55555           
=======================================
  Hits        47291    47291           
  Misses       8264     8264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker/fedora37 Outdated
RUN yum -y install gcc-c++
RUN yum -y install environment-modules gawk vim wget lapack-devel blas-devel \
zlib-devel gsl-devel fftw-devel openmpi-devel boost-devel \
python39 python-devel python-pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Iximiel penso il problema sia qui, devi cambiare
pyhon39 python-devel python-pip
in
pyhon39 python39-devel python39-pip

vedi questo link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already tried here
but yum returns

No match for argument: python39-devel
No match for argument: python39-pip

So I opted for ensurepip, and it seems to work until mdtraj

@GiovanniBussi GiovanniBussi self-assigned this Aug 3, 2023
GiovanniBussi pushed a commit that referenced this pull request Aug 3, 2023
@iximial I removed unrelated changes
@GiovanniBussi
Copy link
Member

Merged manually in c473b4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants