Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GLOBAL keyword to LOAD action #985

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Nov 15, 2023

Description

Knowing the problems with the new direction of pycv in Unix I added the possibility to LOAD shared object with the RTLD_GLOBAL option, if needed the standard behaviour is not changed.

I changed some names in the load method of PlumedMain, for readability.

Target release

I would like my code to appear in release 2.10

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ae54bc5) 84.11% compared to head (7a9de3d) 84.11%.

❗ Current head 7a9de3d differs from pull request most recent head 05ac10b. Consider uploading reports for the commit 05ac10b to get more accurate results

Files Patch % Lines
src/core/PlumedMain.cpp 87.50% 2 Missing ⚠️
src/tools/DLLoader.cpp 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   84.11%   84.11%   -0.01%     
==========================================
  Files         602      602              
  Lines       56083    56092       +9     
==========================================
+ Hits        47176    47183       +7     
- Misses       8907     8909       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiovanniBussi GiovanniBussi merged commit ee93ec2 into plumed:master Nov 15, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants