Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed py37 and py38 from macports CI #989

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Nov 28, 2023

Description

In #967, related to the EOL of python3.7, I lost the "py37" in the macports-CI, here I removed it

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@Iximiel Iximiel marked this pull request as draft November 28, 2023 10:08
@Iximiel
Copy link
Member Author

Iximiel commented Nov 28, 2023

Tests were failing not due to the EOL of 3.7 the error message says:

Error: Processing of port py38-plumed failed
---> Some of the ports you installed have notes:
OpenBLAS has the following notes:
This version is built based on a base architecture for convenience,
which may not be optimized for your system. To build a version
customized for your machine, use the +native variant
py38-pytest has the following notes:
To make the Python 3.8 version of pytest the one that is run when you
execute the commands without a version suffix, e.g. 'pytest', run:

sudo port select --set pytest pytest38

I cnverted this to a draft to check what is the problem

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 634 lines in your changes are missing coverage. Please review.

Comparison is base (943108b) 85.02% compared to head (afb930a) 84.12%.
Report is 52 commits behind head on master.

❗ Current head afb930a differs from pull request most recent head cc94d4f. Consider uploading reports for the commit cc94d4f to get more accurate results

Files Patch % Lines
src/isdb/EMMIVox.cpp 5.54% 596 Missing ⚠️
src/isdb/SAXS.cpp 81.52% 34 Missing ⚠️
src/core/PlumedMain.cpp 87.50% 2 Missing ⚠️
src/pytorch/PytorchModel.cpp 95.65% 1 Missing ⚠️
src/tools/DLLoader.cpp 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   85.02%   84.12%   -0.91%     
==========================================
  Files         601      602       +1     
  Lines       55309    56092     +783     
==========================================
+ Hits        47028    47185     +157     
- Misses       8281     8907     +626     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Iximiel Iximiel marked this pull request as ready for review November 28, 2023 14:42
@Iximiel
Copy link
Member Author

Iximiel commented Nov 28, 2023

I did some experimentation (see here) and I found that there may be linking problems with blas and numpy for python 3.8 and 3.7 in the macports installation, removing them the CI should pass

python 3.7 reached EOL this year and python 3.8 will reach EOL around October 2024

@Iximiel Iximiel changed the title Removed py37 from macports CI Removed py37 and py38 from macports CI Nov 28, 2023
@GiovanniBussi GiovanniBussi merged commit b5bc687 into plumed:master Nov 28, 2023
17 checks passed
@GiovanniBussi
Copy link
Member

@Iximiel should this be backported to maintained versions of PLUMED perhaps?

@Iximiel
Copy link
Member Author

Iximiel commented Nov 28, 2023

Philosophicallly not, but in practice yes, for the sake of the CI working
Tomorrow I'm setting up a rebase for the 2.8 that shall then be merged into the 2.9, hopefully no conflict will arise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants