-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed py37 and py38 from macports CI #989
Conversation
Tests were failing not due to the EOL of 3.7 the error message says:
I cnverted this to a draft to check what is the problem |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 85.02% 84.12% -0.91%
==========================================
Files 601 602 +1
Lines 55309 56092 +783
==========================================
+ Hits 47028 47185 +157
- Misses 8281 8907 +626 ☔ View full report in Codecov by Sentry. |
I did some experimentation (see here) and I found that there may be linking problems with blas and numpy for python 3.8 and 3.7 in the macports installation, removing them the CI should pass python 3.7 reached EOL this year and python 3.8 will reach EOL around October 2024 |
@Iximiel should this be backported to maintained versions of PLUMED perhaps? |
Philosophicallly not, but in practice yes, for the sake of the CI working |
Description
In #967, related to the EOL of python3.7, I lost the "py37" in the macports-CI, here I removed it
Type of contribution
Copyright
COPYRIGHT
file with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulename
in order to make sure the headers of the module are correct.Tests