Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create stream v2 endpoint #254

Merged
merged 15 commits into from
Feb 19, 2020
Merged

Conversation

lewisjkl
Copy link
Contributor

This PR is to add the create topic endpoint for V2.

@lewisjkl lewisjkl linked an issue Feb 18, 2020 that may be closed by this pull request
wondering if these tests are actually useful here. Seems like they are
testing functionality that is totally obvious.
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #254 into master will decrease coverage by 0.51%.
The diff coverage is 23.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   91.47%   90.96%   -0.52%     
==========================================
  Files         133      134       +1     
  Lines        2358     2379      +21     
  Branches      120      119       -1     
==========================================
+ Hits         2157     2164       +7     
- Misses        201      215      +14
Impacted Files Coverage Δ
...in/scala/hydra.ingest/http/IngestionEndpoint.scala 100% <ø> (ø) ⬆️
...ydra/kafka/serializers/TopicMetadataV2Parser.scala 95.74% <ø> (ø) ⬆️
...main/scala/hydra.ingest/http/SchemasEndpoint.scala 97.77% <ø> (ø) ⬆️
...cala/hydra/kafka/endpoints/BootstrapEndpoint.scala 68.18% <ø> (ø) ⬆️
...a/hydra.ingest/http/IngestorRegistryEndpoint.scala 100% <ø> (ø) ⬆️
.../hydra/kafka/endpoints/TopicMetadataEndpoint.scala 100% <ø> (ø) ⬆️
...src/main/scala/hydra.ingest/modules/Algebras.scala 0% <0%> (ø) ⬆️
...rc/main/scala/hydra.ingest/modules/Bootstrap.scala 0% <0%> (ø) ⬆️
...src/main/scala/hydra.ingest/modules/Programs.scala 0% <0%> (ø) ⬆️
...st/src/main/scala/hydra.ingest/app/AppConfig.scala 0% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbaca9...961f755. Read the comment docs.

@lewisjkl lewisjkl marked this pull request as ready for review February 19, 2020 20:29
@lewisjkl lewisjkl requested a review from bretrbs February 19, 2020 21:01
@lewisjkl lewisjkl merged commit b00079b into master Feb 19, 2020
@lewisjkl lewisjkl deleted the feature/create-streamV2-endpoint branch February 19, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra V2 Create Stream Endpoint
4 participants