mocha in CI #51
Closed
mocha in CI #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: in order to do this we need to download and build the circom compiler from source in the CI workflow (not ideal) |
KaiGeffen
requested changes
Aug 19, 2024
| let all_bits: number[] = first_64.concat(last_64); | ||
| return parseInt(all_bits.join(""), 2); | ||
| } | ||
| await circuit.expectPass( { a: a_bits, b: a_bits }, { res: expected_bit_array }); |
There was a problem hiding this comment.
I think that using compute over expectPass is better for interpretability of the results and is in line with expected behavior of testing frameworks that will say something like:
test failed
expect: foo
got: bar
There was a problem hiding this comment.
i will probably close the pr for now since tackling the issue isn't ideal anymore
There was a problem hiding this comment.
oh why not? I likeed the CI
update: I see your above comment now
| @@ -30,6 +30,23 @@ export function hexToBitArray(hex: string): number[] { | |||
| ); | |||
| } | |||
|
|
|||
|
|
|||
| export function pad_num_to_arr128(value: number): number[][] { | |||
There was a problem hiding this comment.
Pulling out these utility methods looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50