Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement multiplication for polyval #54

Closed
wants to merge 25 commits into from
Closed

implement multiplication for polyval #54

wants to merge 25 commits into from

Conversation

thor314
Copy link
Contributor

@thor314 thor314 commented Aug 21, 2024

  • passing test for gfmulx
  • RFC test vector fails
  • comments
  • refactor test code paths: create dir for gfmulx for polyval and ghash
  • implement tests for ghash + format file
  • implement polyval tests
  • implement more thorough polyval testing to inspect LE encoding bug
  • leftshift LE circom written and tested
  • incorporate LE shift changes into polyval_GFMULX
  • gf_mul polyval passing tests
  • note conflict in tests
  • implement ghash mulx
  • clean
  • setup to implement ghash
  • impl reverse_byte array
  • circomkit bug? can't declare input to GHASH
  • ghash tests implemented
  • bitreversal test compares output instead of expectPass
  • Corrected ghash_gfmul comment
  • Added polyval test consistent with ghash
  • lint comments in circuit
  • impl bmul multiplication subroutine
  • impl gfmul (mostly)

@thor314 thor314 closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants