Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underconstrained: new state sum var #36

Closed
Autoparallel opened this issue Aug 15, 2024 · 0 comments
Closed

underconstrained: new state sum var #36

Autoparallel opened this issue Aug 15, 2024 · 0 comments
Labels
bug Something isn't working json question Further information is requested

Comments

@Autoparallel
Copy link
Contributor

Quoting from @devloper in #11:

I believe the sum var is underconstrained. Roughly my logic is that sum is a key component of the state machine and it is currently formed purely through "witness" construction. Notably on line 103 we transition the state machine with mask out.

There are constraints that guarantee the inputs have a certain characteristic, but not constraints on the sum.

My mental model on circom is a bit weak, but in halo I think of the witness & extended witness. The extended witness is the thing generated from all the logic of the circuit. In this case, sum, in your extended witness is computed as a sum, but there are no constraints on that trace cell.

Extended Witess:
[a,b,c,d,sum ]
[1,0,1,0, ?? ]

In my mental model, this sum field does exist in the extended witness and is key to a valid proof generation. However, a malicious prover could populate this value with any value and the proof would still generate.

@Autoparallel Autoparallel added bug Something isn't working question Further information is requested json labels Aug 15, 2024
@Autoparallel Autoparallel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working json question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant