Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parser improvs #75

Merged
merged 9 commits into from
Sep 3, 2024
Merged

feat: parser improvs #75

merged 9 commits into from
Sep 3, 2024

Conversation

lonerapier
Copy link
Collaborator

  • update parser to add:
    • parsing_start as counter, counting each value in start line
    • parsing_header as counter, counting each new header
    • parsing_field_name as flag
    • parsing_field_value as flag
  • adds match field name template
  • adds field value extract template

TODOs:

  • RFC 9112 states that, parsers should support multiple space separators between value (although not strictly). Currently, this isn't supported in our parser.
  • When moving from headers -> body, parsing_header is incremented for first CRLF. So, counts a rogue header, which it shouldn't.
  • Merge response + field value extractor proofs together

Base automatically changed from feat/http-body-extractor to main September 3, 2024 21:05
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review -- looks good.

Going to go into a more in-depth review by trying to use this all in codegen. Lfg

@Autoparallel Autoparallel merged commit 1d814b3 into main Sep 3, 2024
1 check passed
@Autoparallel Autoparallel deleted the feat/parser-improvs branch September 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants