-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: http + json extended example #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few thoughts
@@ -0,0 +1,3 @@ | |||
GET /v1/me/top/artists?time_range=medium_term&limit=1 HTTP/1.1 | |||
Host: api.spotify.com | |||
Authorization: Bearer BQBXRpIm2NL08akEiaxB5l42eiq6Zd9Q0S2-0Q4k0CMoa5u8o_ah_Ddjxt6Mv3226AEDyKYcFPpgw_6Asg-Y2hJpcuMya8wzqyqgiV-KH0vcEq7EFzODXoaBxsB0wryVCWDF6p5dqcpIHOz4QJqQa9mUA6sFzYNyECglT-BGcRe_N9f_3aqYTGQ-kkE-devPkPkEfDcbziT6mOzJfGRzLw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to commit this token...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It expires every hour, at this point even I can't use it lol. but, yeah, will add this to gh secrets.
"headerName1": "content-type", | ||
"headerValue1": "application/json; charset=utf-8", | ||
"headerName2": "content-encoding", | ||
"headerValue2": "gzip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting. If the content is gzip vs identity, this likely fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use Accept-Encoding: identity
in request and perform LockHeader
proof on request, right?
…able symbols in JSON parser
93f02dd
to
9861bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! Lot's of good additions and clean up.
I think my review may be a bit superficial as I want to get to use this outside of this context, that will really be the most telling if we have this working in the best way possible :)
Also note I pushed up a README change. |
@lonerapier see #92 to see if that fixes test |
Closes #8
Adds:
Run
npx mocha -g spotify
to run spotify example. Currently, we don't match the output becausesym
file is too big to be loaded, due to unconstrained signals. However, running circuit manually with circom, snarkjs works.To run codegen, which will generate circuit in
main/spotify_top_artists.circom
:and then compile circuits and generate witness using circomkit.