Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock header max length #99

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Lock header max length #99

merged 7 commits into from
Oct 22, 2024

Conversation

lonerapier
Copy link
Collaborator

No description provided.

Autoparallel
Autoparallel approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and all works well. One thing I would do in the future is consider having a way to test that each step performs properly in the NIVC (at least for JSON). However, I can see they work now, so we should add these tests later.

@Autoparallel Autoparallel merged commit c220c40 into feat/nivc-circuits Oct 22, 2024
2 checks passed
@Autoparallel Autoparallel deleted the lock-header-max-length branch October 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonerapier @Autoparallel