feat: basic polynomial arithmetic #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now everything compiles again. Will work to clean this all up and get all the tests to pass.
Needed to get rid of these to make the arithmetic possible for now.
Need to make a fix that the leading term is nonzero when we do things like add/sub. This should fix some problems.
commit f9aa66e Author: Waylon Jepsen <[email protected]> Date: Tue May 7 09:00:35 2024 -0600 curves in sage (#39) commit 63ce62f Author: Waylon Jepsen <[email protected]> Date: Mon May 6 17:46:22 2024 -0600 fix: lock commit d1c84eb Author: Colin Roberts <[email protected]> Date: Mon May 6 16:39:25 2024 -0700 feat: home-baked `FiniteField` trait (#38) * feat: new `FiniteField` trait Now everything compiles again. Will work to clean this all up and get all the tests to pass. * fix: `GF101` tests pass * fix: reimplement monty optimizations * clean: udeps --------- Co-authored-by: Waylon Jepsen <[email protected]> commit 96c8b66 Merge: fb27e5f 62a9a57 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon May 6 23:26:56 2024 +0000 Merge pull request #42 from pluto/dependabot/cargo/anyhow-1.0.83 Bump anyhow from 1.0.82 to 1.0.83 commit 62a9a57 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 6 23:26:43 2024 +0000 Bump anyhow from 1.0.82 to 1.0.83 Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.82 to 1.0.83. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.82...1.0.83) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
I'm not sure why there are conflicts either. I've already merged in from main, so that's annoying. |
2 tasks
Yeah this is weird it is saying a few things are diffs when they shouldn't be. I am down to merge this after the conflicts are resolved. |
commit 2637594 Author: Waylon Jepsen <[email protected]> Date: Thu May 9 10:38:12 2024 -0600 curves: Second curve group and some test (#49) * chore: tests + scalar multiplication * fmt * wip: compiles, but generator point is broken * wip * fix mul, generator and add hardcoded tests (#51) * fix mul, generator and add hardcoded tests * fix generator test * wip * fix: test fails when rng has no inverse --------- Co-authored-by: Sambhav <[email protected]> commit def9371 Author: Waylon Jepsen <[email protected]> Date: Thu May 9 09:36:25 2024 -0600 docs: readme (#46) * docs: readme * wip: pairing check * docs * Update README.md Co-authored-by: Colin Roberts <[email protected]> * Update README.md Co-authored-by: Colin Roberts <[email protected]> --------- Co-authored-by: Colin Roberts <[email protected]> commit ab0d374 Author: Sambhav <[email protected]> Date: Wed May 8 03:00:15 2024 +0530 Extension field (#44) * feat: extension field init * add test * add more tests and comments * move pow impl default to trait commit f9aa66e Author: Waylon Jepsen <[email protected]> Date: Tue May 7 09:00:35 2024 -0600 curves in sage (#39) commit 63ce62f Author: Waylon Jepsen <[email protected]> Date: Mon May 6 17:46:22 2024 -0600 fix: lock commit d1c84eb Author: Colin Roberts <[email protected]> Date: Mon May 6 16:39:25 2024 -0700 feat: home-baked `FiniteField` trait (#38) * feat: new `FiniteField` trait Now everything compiles again. Will work to clean this all up and get all the tests to pass. * fix: `GF101` tests pass * fix: reimplement monty optimizations * clean: udeps --------- Co-authored-by: Waylon Jepsen <[email protected]> commit 96c8b66 Merge: fb27e5f 62a9a57 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon May 6 23:26:56 2024 +0000 Merge pull request #42 from pluto/dependabot/cargo/anyhow-1.0.83 Bump anyhow from 1.0.82 to 1.0.83 commit 62a9a57 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 6 23:26:43 2024 +0000 Bump anyhow from 1.0.82 to 1.0.83 Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.82 to 1.0.83. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.82...1.0.83) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
I had to merge this 4 million times |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites our
Polynomialdefinition a bit removing the const generics. These made the arithmetic quite problematic as generic const expressions are not really workable at the moment.Closes #28