Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup curve module #59

Merged
merged 4 commits into from
May 13, 2024
Merged

chore: cleanup curve module #59

merged 4 commits into from
May 13, 2024

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented May 10, 2024

Small refactor and removal of unused items in the curve module.

Edit: Going to do a bit more here!

@Autoparallel Autoparallel marked this pull request as draft May 10, 2024 22:13
@0xJepsen
Copy link
Contributor

hmmm yeah i don't know actually. There is maybe some benefit to thinking of each curve as a distinct object, but it is also the same curve over different fields. My autism is telling me to just implement like a group trait, but i know that is over kill. my curry howard context is getting stuck.
Thinking about the pairing functing it can only exist between two curve that are "pairing friendly" which technically means that the second curve is is the extension field with degree k where k is the smallest number such that the embedding degree r | p^k - 1. So maybe the pairing function should check that somehow? It will take in elements in g1, and g2 and then output something in some field (idk what field yet)
I guess my final answer is: It depends on whether we want to relate the two curve groups as being pairing friendly or not.

@Autoparallel Autoparallel marked this pull request as ready for review May 13, 2024 16:04
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xJepsen 0xJepsen merged commit e09a73a into main May 13, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
@lonerapier lonerapier deleted the chore/curve-cleanup branch January 18, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants