-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/dsl #60
Feat/dsl #60
Conversation
This is lookin' pretty good. Would love to work with you on this as it seems like a crucial part of this project. |
Sure @Autoparallel, will connect with you. This is currently a straight port of plonkathon's DSL compiler. Liked their approach a lot, so I didn't do any modifications yet. Right now, adding tests and documentation. Would love your help as there's significant work still pending here. |
@Autoparallel @0xJepsen PR is mostly done, will rebase on #63 and add scalar field when it's merged. Would love your review on this. |
This is looking so good. I can give a passing review for sure, but I need to spend more time on this. Let me wait until you merge in my other PR which just got merged into main now :) |
@Autoparallel done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im down to merge this in nice work!
added a README with a walkthrough on how DSL is parsed and required polynomials are created. If @Autoparallel doesn't have any suggestions, I think, we can merge this |
This PR fixes/closes issue #53
Very rough right now, don't review.