update aes-version and add updates aes-circuits #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to at least bring in some kind of tests here. I don't want to allow merging in a circuit that doesn't come with a way to see that what we are releasing works properly. |
|
I'll add some here today |
…into aes-circuits
|
Things are failing, let's discuss this today if we can. I think there's just better ways to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Some open questions: This just brings in the entry point for now. Do we want to eventually bring in everything? Does this mean also all the CI and tests from circom kit? I kinda like this idea but don't want to bloat it up immediately. This here should at least at the most up to date circuits to our build pipeline so we can get those artifacts downstream asap.