feat: download artifact and attach at release #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Autoparallel added some info regarding the PR, and linked an issue for better discussion. Thanks for pointing this out. |
|
Bah... I really want to keep this simple. Conventional commits seems like a weird choice of overhead to me, though I'm not totally against it. I think the thing is here that we will likely never use a patch version at all. Version changes here are going to be large. |
Autoparallel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates a new release with
semantic-releaseand attach the artifact generated during pull request.previous workflow generated the artifact but was not working with semantic release.
But due to semantic release, we'll have to follow conventional commits. Can revert this and use manual version management as per discussion.