Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AES NIVC + build #24

Merged
merged 21 commits into from
Nov 4, 2024
Merged

feat: AES NIVC + build #24

merged 21 commits into from
Nov 4, 2024

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Nov 1, 2024

Working AES NIVC chain.

Golfed down the circuit back to reasonable constraint level.

TODO:

  • Generate multiple sets of artifacts, say now also a 512b version and make sure they get put into separate zip files in the PR artifacts and merge to main release workflows.

If someone sees this and can do this final TODO, that would be great.


Noticed that json_mask_object is now the heaviest circuit we have. I had to choose a pretty small MAX_KEY_LENGTH. We should work on this

Also the zip file seems to be really large now...

On this note, I found that aes_gctr_nivc_1024b.r1cs and http_lock_header_1024b.r1cs are the offenders here:
image

@Autoparallel Autoparallel changed the title feat: AES NIVC feat: AES NIVC + build Nov 1, 2024
Autoparallel and others added 3 commits November 1, 2024 18:04
creates two new builds for 512 bytes and 256 bytes. Also runs wit calc in the CI tests whereas before it was just being installed in the artifacts jobs and being used. I double checked the artifact Job and the make file and believe that they will both correctly make separate zips for each build. There was also one miscellaneous empty file with a .built extension that i assumed was a mistake so i removed it.
@0xJepsen 0xJepsen self-requested a review November 4, 2024 08:55
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, maybe after / during planning meeting we can go over my small additions (if you like, mainly just addressed your todo) and merge

circuits/aes-gcm/nivc/aes-gctr-nivc.circom Outdated Show resolved Hide resolved
@0xJepsen 0xJepsen merged commit fff0a65 into main Nov 4, 2024
3 checks passed
@lonerapier lonerapier deleted the feat/circuits-build branch December 12, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants