-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AES NIVC + build #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 69c6129.
Also reduced constraints on AESGCTR
1 task
creates two new builds for 512 bytes and 256 bytes. Also runs wit calc in the CI tests whereas before it was just being installed in the artifacts jobs and being used. I double checked the artifact Job and the make file and believe that they will both correctly make separate zips for each build. There was also one miscellaneous empty file with a .built extension that i assumed was a mistake so i removed it.
0xJepsen
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, maybe after / during planning meeting we can go over my small additions (if you like, mainly just addressed your todo) and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working AES NIVC chain.
Golfed down the circuit back to reasonable constraint level.
aes-proof
+parser-attestor
circuits #19builds/
dir withtarget_*b
dirs and update artifact/release CI #21TODO:
If someone sees this and can do this final TODO, that would be great.
Noticed that
json_mask_object
is now the heaviest circuit we have. I had to choose a pretty smallMAX_KEY_LENGTH
. We should work on thisAlso the zip file seems to be really large now...
On this note, I found that
aes_gctr_nivc_1024b.r1cs
andhttp_lock_header_1024b.r1cs
are the offenders here: