remove var usage in lock header #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonerapier
commented
Nov 4, 2024
| @@ -101,13 +103,13 @@ template FirstStringMatch(dataLen, maxKeyLen) { | |||
| stringMatch[idx] = IsEqualArray(maxKeyLen); | |||
| stringMatch[idx].in[0] <== key; | |||
| for (var key_idx = 0 ; key_idx < maxKeyLen ; key_idx++) { | |||
| isFirstMatchAndInsideBound[idx * maxKeyLen + key_idx] <== (1 - matched) * (1 - isKeyOutOfBounds[key_idx]); | |||
| isFirstMatchAndInsideBound[idx * maxKeyLen + key_idx] <== (1 - isMatched[idx]) * (1 - isKeyOutOfBounds[key_idx]); | |||
There was a problem hiding this comment.
@0xJepsen circom doesn't like updating a signal using an already updating var
0xJepsen
approved these changes
Nov 4, 2024
|
Okay i don't want to merge this without running CI and rebuilding the right artifacts. But i do think we should build artifacts with these new perf gains asap. |
|
LFG, we spin green to win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30
reduces r1cs file size for
http_lock_headercircuit from 1.93G to 43MB by removing var usage inFirstStringMatchtemplate.Note: this doesn't happen with all
vars, as can be noted here, only happening for iteratingvaraccessed again in a separate signal/var.