Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract circuit #32

Merged
merged 9 commits into from
Nov 5, 2024
Merged

fix: extract circuit #32

merged 9 commits into from
Nov 5, 2024

Conversation

lonerapier
Copy link
Collaborator

  • remove value from output for final extract circuit
  • complete full NIVC test

@lonerapier lonerapier requested a review from 0xJepsen November 5, 2024 07:03
0xJepsen
0xJepsen approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work this looks good.

@Autoparallel Autoparallel self-requested a review November 5, 2024 17:07
Autoparallel
Autoparallel requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It's not clear why we are doing this? I'm not necessarily against it, but also why?

@lonerapier
Copy link
Collaborator Author

Why? It's not clear why we are doing this? I'm not necessarily against it, but also why?

do you mean removal of output value? I thought that all circuits need to have same public input output length, that's why removed it. Is it not the case for last circuit?

@Autoparallel
Copy link
Contributor

value isn't a public output though. It's private and it won't cause issue with the NIVC IO I'm pretty sure. Was it failing?

@lonerapier lonerapier merged commit e50209a into main Nov 5, 2024
3 checks passed
@lonerapier lonerapier deleted the fix/extract-circuit branch November 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonerapier @Autoparallel @0xJepsen