Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NIVC hash chain #36

Merged
merged 19 commits into from
Nov 12, 2024
Merged

feat: NIVC hash chain #36

merged 19 commits into from
Nov 12, 2024

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Nov 7, 2024

WIP

Working to reduce public io signals to 1, just pass a hashchain value through AES and into the subsequent circuits where the hashchain will be computed again.


I am using circomkit a bit more to help see constraint counts and what not as I'm going through and I've found we have a good bit of warnings again.


  • AES should also take in CT and verify it.

@Autoparallel
Copy link
Contributor Author

Currently fighting a bug where circomkit isn't getting the step_out value from the circuit. I know it's computing properly, but it isn't giving me it in TypeScript:

it("NIVC_CHAIN", async () => {
       //..
        let parseAndLockStartLine = await httpParseAndLockStartLineCircuit.compute({ step_in: temp_step_in, data: http_response_plaintext, beginning: beginningPadded, beginning_length: beginning.length, middle: middlePadded, middle_length: middle.length, final: finalPadded, final_length: final.length }, ["step_out"]); // THIS GIVES ME `[]` `"step_out"` even though I can see it's correct with circom logs. 

This is in the NIVC_FULL test

@0xJepsen 0xJepsen marked this pull request as ready for review November 11, 2024 12:54
@Autoparallel
Copy link
Contributor Author

Did you guys just finish this up for me 🥹

@0xJepsen
Copy link
Contributor

Did you guys just finish this up for me 🥹

yes <3

@Autoparallel
Copy link
Contributor Author

LET'S FUCKING MERGE IT THEN

@Autoparallel Autoparallel merged commit 2dd1558 into main Nov 12, 2024
3 checks passed
@lonerapier lonerapier deleted the feat/hash-chain branch November 12, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: NIVC Hash Chain
3 participants