feat: generic chunked aes nivc #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
force-pushed
the
feat/generic-chunked-aes-nivc
branch
from
ff6241c to
e18a2b7
Compare
lonerapier
reviewed
Nov 13, 2024
| if(i == 0) { | ||
| hash = PoseidonChainer()([step_in[0],packedPlaintext[i]]); | ||
| } else { | ||
| hash = PoseidonChainer()([hash, packedPlaintext[i]]); |
There was a problem hiding this comment.
this doesn't look constrained properly? i'm curious about r1cs size as well because this was the exact reason of increased size
|
what if i want to do 15 folds in a 2 chunk AES? is that possible or we have to add 2 different circuits to the ROM? so |
lonerapier
reviewed
Nov 13, 2024
suggestion from Sambhav Co-authored-by: Sambhav Dusad <[email protected]>
I think we'd probably pick an optimal size be it 2,4,8 chunks at a time, then always have a single chunk circuit as backup to fill in the remainder. |
|
As of the last changes we have: |
lonerapier
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a foldable AES GCTR for arbitrary amount of chunks. Tested with both 1 and 2 chunk mode.