feat: nonzero DataHasher
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonerapier
approved these changes
Nov 14, 2024
lonerapier
force-pushed
the
feat/nonzero-data-hasher
branch
from
430aff0 to
2fc4252
Compare
|
rebased it from main, merging it after CI runs green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataHasherthat does not hash a chunk of 16 bytes if they are ALL zero.Reasoning
We want to be able to just AES encrypt 200 bytes and use the ciphertext from the server if we are going to use the 512b circuits. Without this, we need to AES encrypt 512b so that the use of
DataHasherinHttpNIVCwould match. NowHttpNIVCignores 0 padding at the end of bytes and will only hash the relevant plaintext bytes (e.g., in our example: 200b).