feat!: Manifest v2 #541
Open
feat!: Manifest v2 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-roslaniec
force-pushed
the
feat/manifest-v2
branch
from
2317ec5 to
ba46b3e
Compare
* feat: update template validation vars in manifest * refactor: move template vars into a separate file * refactor: introduce a separate template error
* remove redundant variables in manifest * ci: remove pull request branch filter
* feat!: implement extractors and predicates test: add predicate tests refactor: create predicate error type with concrete cases feat: extract values from notary response test: update http tests chore: add more concrete extractor error types refactor: use extractor error in return types feat: add string and array predicate types refactor: initial integration with notary test: test regex predicates * chore: remove default values from fixtures * chore: document a todo * (wip): self review * test: add coinbase fixtures to e2e tests * (wip): fix after rebase
piotr-roslaniec
force-pushed
the
feat/manifest-v2
branch
from
689a4bc to
05e92ad
Compare
feat: implement html extractor feat: integrate html format with the notary feat: support multiple selectors in html format --------- Co-authored-by: Sambhav Dusad <[email protected]>
* feat: return aggregated errors from manifest validation * chore: improve error tracing --------- Co-authored-by: Sambhav Dusad <[email protected]>
piotr-roslaniec
requested review from
mattes,
devloper,
drewjenkins,
Autoparallel,
0xFloyd,
lonerapier and
0xJepsen
|
Dear reviewers, please see the original issue and the previously merged PR if you haven't already: #514 |
0xJepsen
reviewed
Mar 11, 2025
| cargo binstall --no-confirm --version ${MDBOOK_VERSION} mdbook | ||
| cargo binstall --no-confirm --version ${MDBOOK_KATEX_VERSION} mdbook-katex | ||
| cargo binstall --no-confirm --version ${MDBOOK_LINKCHECK_VERSION} mdbook-linkcheck | ||
| cargo +nightly-2025-02-20 binstall --no-confirm --version ${MDBOOK_VERSION} mdbook |
There was a problem hiding this comment.
do we still need these nightly versions here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of reviewing:
Related Issues