fixed typo in welch function in emg signal processing #11
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Dear @johanna-einsiedler, In the name of the entire PLUX team, I would like to sincerely thank you for your valuable action and for being a proactive member of our esteemed community of users 😊 Regarding the Pull-Request, despite being very similar, the Due to this circumstance, hoping that you don't consider inadequate, before accepting/rejecting the Pull-Request, the team would like to understand which will be the benefits of the current change (window type) for the EMG signal processing. We will carefully wait for your valuable feedback, wishing, in the meantime, a continuation of an excellent day. My best and sincere regards, |
|
Hi Ramos!
Thanks for pointing this out!
In this case - if I am not mistaken - you should use the numpy package.
Right now, I think you are using scipy signals which does only have a 'hamming' but not a 'hanning' window: https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.welch.html
At least I am getting an error when trying to run the code that 'hanning' is not implemented and it is also not in the list of available window function (https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.get_window.html#scipy.signal.get_window).
Hoper that helps clarify - and of course no problem if you don't accept the pull request!
Best,
Johanna
Gesendet: Freitag, 07. Juni 2024 um 14:25 Uhr
Von: "GRamosPlux" ***@***.***>
An: "pluxbiosignals/biosignalsnotebooks" ***@***.***>
Cc: "Johanna E" ***@***.***>, "Mention" ***@***.***>
Betreff: Re: [pluxbiosignals/biosignalsnotebooks] fixed typo in welch function in emg signal processing (PR #11)
Dear @johanna-einsiedler,
In the name of the entire PLUX team, I would like to sincerely thank you for your valuable action and for being a proactive member of our esteemed community of users 😊
Regarding the Pull-Request, despite being very similar, the hanning window is also a valid window auxiliary link.
Due to this circumstance, hoping that you don't consider inadequate, before accepting/rejecting the Pull-Request, the team would like to understand which will be the benefits of the current change (window type) for the EMG signal processing.
We will carefully wait for your valuable feedback, wishing, in the meantime, a continuation of an excellent day.
My best and sincere regards,
@GRamosPlux
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Dear @johanna-einsiedler, The team is very grateful for your extremely constructive feedback, you are totally correct, the typo definitively exists, our sincere apologies for my mistake! In this case, hoping that you don't consider our suggestion inadequate, we would like to recommend replacing I will wait for your always essential and valuable feedback regarding the previous suggestion 😉 My best and sincere regards, |
There was a typo in the welch function specification (both in the package and the notebook)