Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memkind hmat 'I' example templates #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PatKamin
Copy link

@PatKamin PatKamin commented Sep 30, 2022

Not verified on a test server.
#12 needs to be merged first.


This change is Reviewable

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 7 unresolved discussions (waiting on @lukaszstolarczuk and @PatKamin)


templates/examples/I/body.tmpl line 5 at r1 (raw file):

<p class="intro">
Different memory types can have different performance characteristics. They
can be distinguished by values of their latency, capacity or bandwidth.

, or


templates/examples/I/body.tmpl line 28 at r1 (raw file):

allocations between a low latency memory and a high capacity memory is achieved
by utlising two kinds (you can think of them as an additional parameter to
malloc()): MEMKIND_LOWEST_LATENCY_LOCAL and MEMKIND_HIGHEST_CAPACITY.

you can use <code>malloc()</code> syntax for code highlighting and maybe some <b> for the consts


templates/examples/I/body.tmpl line 41 at r1 (raw file):


<p>
This program allocates hashmap, keys and data using different memory

, and


templates/examples/I/body.tmpl line 71 at r1 (raw file):

memory type available is DRAM, too. One may see these memkind kinds as a hint
for the allocator as to whether allocated data should have fast access, huge
storage or, not used in this example, fast bandwidth. You can also play with

something's wrong with the comma after or


templates/examples/I/body.tmpl line 75 at r1 (raw file):

<a href="https://pmem.io/memkind/manpages/memkind.3/#kind">here</a>.
<p>
In the <a href="I">next example</a>, you can experiment with some Java programs

did you mean "J" and actually I'm not sure if we need this link - it's totally different example...


templates/examples/I/description.tmpl line 8 at r1 (raw file):

This example shows allocation tiering with the usage of memkind.
This is achieved by utilising memory performance characteristics provided by
kernel and the libhwloc library. Allocation tiering is based on lowest latency

the lowest


templates/examples/I/description.tmpl line 9 at r1 (raw file):

This is achieved by utilising memory performance characteristics provided by
kernel and the libhwloc library. Allocation tiering is based on lowest latency
and highest capacity tiers.

the highest

Copy link
Author

@PatKamin PatKamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 6 unresolved discussions (waiting on @lukaszstolarczuk)


templates/examples/I/body.tmpl line 5 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

, or

Done.


templates/examples/I/body.tmpl line 28 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

you can use <code>malloc()</code> syntax for code highlighting and maybe some <b> for the consts

Done.


templates/examples/I/body.tmpl line 41 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

, and

Done.


templates/examples/I/body.tmpl line 71 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

something's wrong with the comma after or

Done.


templates/examples/I/body.tmpl line 75 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

did you mean "J" and actually I'm not sure if we need this link - it's totally different example...

Done, removed.


templates/examples/I/description.tmpl line 8 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

the lowest

Done.


templates/examples/I/description.tmpl line 9 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

the highest

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants