Refactored error handling

pmill · Mar 3, 2016 · 8d43ffd · 8d43ffd
1 parent d8c1d47
commit 8d43ffd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/pmill/Plesk/CreateSecretKey.php b/src/pmill/Plesk/CreateSecretKey.php
@@ -53,7 +53,7 @@ public function __construct(array $config, array $params = [])
     protected function processResponse($xml)
     {
         if ($xml->{'secret_key'}->create->result->status == 'error') {
-            throw new ApiRequestException($xml->{'secret_key'}->create->result->errtext);
+            throw new ApiRequestException($xml->{'secret_key'}->create->result);
         }
 
         $this->key = (string)$xml->{'secret_key'}->create->result->key;

diff --git a/src/pmill/Plesk/DeleteSubscription.php b/src/pmill/Plesk/DeleteSubscription.php
@@ -3,6 +3,9 @@
 
 class DeleteSubscription extends BaseRequest
 {
+    /**
+     * @var string
+     */
     public $xml_packet = <<<EOT
 <?xml version="1.0"?>
 <packet>
@@ -16,22 +19,26 @@ class DeleteSubscription extends BaseRequest
 </packet>
 EOT;
 
-	protected $default_params = array(
-		'id'=>NULL,
-	);
+    /**
+     * @var array
+     */
+    protected $default_params = array(
+        'id' => null,
+    );
 
     /**
-     * Process the response from Plesk
+     * @param $xml
      * @return bool
+     * @throws ApiRequestException
      */
     protected function processResponse($xml)
     {
-    	$webspace = $xml->webspace->del;
+        $webspace = $xml->webspace->del;
 
         if ($webspace->result->status == 'error') {
             throw new ApiRequestException($webspace->result);
         }
 
-        return TRUE;
+        return true;
     }
 }