Block: (Walls) implement tall/short connections #6624
Conversation
src/block/Wall.php
Outdated
| foreach(Facing::HORIZONTAL as $facing){ | ||
| $block = $this->getSide($facing); | ||
| if($block instanceof static || $block instanceof FenceGate || $block instanceof Thin || $block->getSupportType(Facing::opposite($facing)) === SupportType::FULL){ | ||
| if(!isset($this->connections[$facing])){ | ||
| $this->connections[$facing] = WallConnectionType::SHORT; | ||
| if($this->getSide(Facing::UP)->getTypeId() == BlockTypeIds::AIR) { |
There was a problem hiding this comment.
| if($this->getSide(Facing::UP)->getTypeId() == BlockTypeIds::AIR) { | |
| if($this->getSide(Facing::UP)->getTypeId() === BlockTypeIds::AIR){ |
I'm also fairly sure the logic for this is more complex than just checking for air.
There was a problem hiding this comment.
Ill do some more testing but I haven't found any issues yet.
There was a problem hiding this comment.
Yeah gonna have to add more logic, this isn't the indented state
There was a problem hiding this comment.
Defiantly issues, will continue testing and implementing more logic for vertical connections
dktapps
added
Category: Gameplay
|
just a visual test |
|
Yeah i'm working on it now, i'm implementing the logic from dragonfly. |
| Fence::class => Facing::opposite($face) === Facing::DOWN || Facing::opposite($face) === Facing::UP, | ||
| Hopper::class => Facing::opposite($face) === Facing::UP, | ||
| Slab::class => $side->getSlabType() === SlabType::DOUBLE || ($side->getSlabType() === SlabType::TOP && Facing::opposite($face) === Facing::UP) || Facing::opposite($face) === Facing::DOWN, | ||
| Stair::class => (!$side->isUpsideDown() && Facing::opposite($face) === Facing::DOWN) || |
There was a problem hiding this comment.
No way, there has to be a better way than hardcoding logic for every block...
There was a problem hiding this comment.
The supportType can probably be used here (juste the idea, i don't have checked)
| Fence::class => Facing::opposite($face) === Facing::DOWN || Facing::opposite($face) === Facing::UP, | ||
| Hopper::class => Facing::opposite($face) === Facing::UP, | ||
| Slab::class => $side->getSlabType() === SlabType::DOUBLE || ($side->getSlabType() === SlabType::TOP && Facing::opposite($face) === Facing::UP) || Facing::opposite($face) === Facing::DOWN, | ||
| Stair::class => (!$side->isUpsideDown() && Facing::opposite($face) === Facing::DOWN) || |
There was a problem hiding this comment.
The supportType can probably be used here (juste the idea, i don't have checked)
| if (!$connected){ | ||
| if($side instanceof Wall || $side instanceof Thin) $connected = true; | ||
| if($side instanceof FenceGate && $side->getFacing() === $face) $connected = true; | ||
| } |
There was a problem hiding this comment.
all in one if can be done here
Related issues & PRs
Behavioural changes
Changed how walls behave with block on top of them.
Tests