refactor: split for flat #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +24 B (+0.56%) Total Size: 4.3 kB
|
dai-shi
approved these changes
Nov 21, 2024
The v9 wants the reference to the plugin definition in the config and v8 would just internally require it and handle it by using the plugin name's I thought it'd just work but it didn't. The tests probably will fail, will merge once I'm done fixing them and adding tests for both configs. I don't want to sit and setup eslint configs again and again 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!Breaking Change
Previous compat export for both v8 and v9 didn't work as expected in v8 versions post compilation of the library.
Splitting the recommended config into 2 to keep the original v8 compat