Fix/proposal links #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envin3
force-pushed
the
fix/proposal-links
branch
from
cf497b1
to
3871df3
Compare
oliviera9
suggested changes
Jan 5, 2024
| } | ||
| link.setAttribute( | ||
| 'onClick', | ||
| '{ ' + |
There was a problem hiding this comment.
Factor out into a function taking stringified id as a parameter
|
|
||
| useEffect(() => { | ||
| // // Function to perform search and replace within the iframe | ||
| const performSearchAndReplace = async () => { |
There was a problem hiding this comment.
This function is too complex in my opinion, and needs refactoring to make it smaller and easier to read.
envin3
force-pushed
the
fix/proposal-links
branch
from
3871df3
to
6171b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken links on dao proposals.
PIP-33 links are wrapped in a google search link and are not modifiable. When clicking the link the google search generates a redirectory that the browser blocks for security reasons. The output looks like:
This fix aim is to modify the contain of the iframe in which the proposal is loaded and intecept all links click to check that the document loads only direct links.