Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ethereum): <- add PTokenRouter Metadata event parser to that #21

Merged
merged 5 commits into from
Feb 22, 2024
Merged

feat(ethereum): <- add PTokenRouter Metadata event parser to that #21

merged 5 commits into from
Feb 22, 2024

Conversation

ubordignon
Copy link
Contributor

Following pnetwork-association/ptokens-router#8, a new struct and parser for the Metadata event are added to the ethereum package.

@ubordignon ubordignon requested a review from gskapka February 19, 2024 17:11
@ubordignon ubordignon force-pushed the pnetwork_router_metadata_event branch 2 times, most recently from 06d0a9e to 9541b20 Compare February 19, 2024 18:27
gskapka
gskapka suggested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please bump the minor version number in ./common/ethereum/Cargo.toml

Also, given this receipt here, can you grab that as a sample and write a test for this mod to make sure we correctly parse the event from it?

common/ethereum/src/eth_contracts/erc777_token.rs Show resolved Hide resolved
common/ethereum/src/eth_contracts/ptokens_router.rs Outdated Show resolved Hide resolved
common/ethereum/src/eth_contracts/ptokens_router.rs Outdated Show resolved Hide resolved
@ubordignon ubordignon force-pushed the pnetwork_router_metadata_event branch from 9541b20 to 6b4dede Compare February 20, 2024 10:50
@gskapka
Copy link
Contributor

gskapka commented Feb 20, 2024

Oh, and also could you re-export PTokensRouterMetadataEvent from the lib.rs so we can use it elsewhere please?

@ubordignon ubordignon force-pushed the pnetwork_router_metadata_event branch from 6b4dede to fd1f827 Compare February 20, 2024 17:38
gskapka
gskapka suggested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more changes.

common/ethereum/src/eth_contracts/ptokens_router.rs Outdated Show resolved Hide resolved
common/ethereum/src/eth_contracts/ptokens_router.rs Outdated Show resolved Hide resolved
@ubordignon ubordignon force-pushed the pnetwork_router_metadata_event branch from fd1f827 to 9e1e228 Compare February 21, 2024 11:36
@gskapka gskapka self-requested a review February 22, 2024 10:48
gskapka
gskapka approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@gskapka gskapka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing what I'm currently on which relies on this is working as expected, so LGTM!

common/ethereum/src/eth_contracts/test_utils/mod.rs Show resolved Hide resolved
@gskapka gskapka mentioned this pull request Feb 22, 2024
Merged
@ubordignon ubordignon merged commit 29f850d into master Feb 22, 2024
5 checks passed
@ubordignon ubordignon deleted the pnetwork_router_metadata_event branch February 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gskapka gskapka gskapka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubordignon @gskapka