Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bpm #54

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Fix/bpm #54

merged 3 commits into from
Oct 2, 2023

Conversation

envin3
Copy link
Collaborator

@envin3 envin3 commented Oct 2, 2023

No description provided.

@envin3 envin3 requested a review from oliviera9 October 2, 2023 07:37
oliviera9
oliviera9 reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would refactor a lil bit. Then remember to bump version

@oliviera9
Copy link
Contributor

If you have time it might be worth adding a test to the new getBpmInfo function with a mocked bpm.

oliviera9
oliviera9 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/hooks/use-swap-info.js Outdated Show resolved Hide resolved
@envin3 envin3 merged commit 4ec3414 into master Oct 2, 2023
4 checks passed
@envin3 envin3 deleted the fix/bpm branch October 2, 2023 08:24
@oliviera9 oliviera9 restored the fix/bpm branch October 2, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviera9 oliviera9 oliviera9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@envin3 @oliviera9