feat(erc777): <- add custom function call when minting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
d333412
to
a8f41f7
Compare
oliviera9
commented
Jan 29, 2024
oliviera9
force-pushed
the
feat/call-with-user-data
branch
3 times, most recently
from
59e3e37
to
37ac0d0
Compare
gskapka
suggested changes
Jan 29, 2024
oliviera9
force-pushed
the
feat/call-with-user-data
branch
5 times, most recently
from
37a1354
to
9b4e719
Compare
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
9b4e719
to
b577026
Compare
gskapka
suggested changes
Jan 30, 2024
oliviera9
force-pushed
the
feat/call-with-user-data
branch
2 times, most recently
from
efa78c0
to
3c6f1ca
Compare
|
I just added a test where the recipient contract does not implement the IPReceiver interface. |
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
3c6f1ca
to
bdb280e
Compare
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
bdb280e
to
da41228
Compare
Contrary to try/catch, the low-level call to a non-contract address does not revert, thus allowing to write user data in the transaction.
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
da41228
to
118d854
Compare
|
Update: Decision has been made to use |
|
In order, I added unit tests for return bombing in 54549d2, and verified they fail. |
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
33b0f26
to
c2ba176
Compare
oliviera9
commented
Feb 16, 2024
gskapka
suggested changes
Feb 16, 2024
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
c2ba176
to
e3ce226
Compare
oliviera9
commented
Feb 20, 2024
oliviera9
force-pushed
the
feat/call-with-user-data
branch
2 times, most recently
from
b372ee7
to
64b2929
Compare
oliviera9
force-pushed
the
feat/call-with-user-data
branch
from
5d378a8
to
65b0d8c
Compare
|
Approved in pvt with @themetaseq & @wernervoncroy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ERC777 hooks have been removed, it's impossible to have a contract called when minting the pToken.
This PR adds a
IPReceiverinterface which exposes areceiveUserData()function that is called when minting the pToken.