-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert site to SvelteKit #466
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I’m just poking around and this makes sense to me FWIW :)
@pngwn are there any plans to merge this? it appears https://mdsvex.pngwn.io/playground is still broken. |
Hm, it appears the playground still doesn't work...I guess this PR was addressing a different issue with the playground then :( |
No, this PR just didn't work. |
I'll fix. |
What was it that didn't work about the PR? I didn't notice anything in my own testing |
just exploded in the build, some weird module issue not sure yet. I'm gonna debug it tomorrow but I'm just gonna fix the playground issue first. |
I'm not even convinced that the module that was causing issues is even used, so i find it a bit weird tbh. But it was something to do with a cjs -> esm transformation somewhere (a problem that will haunt me till i die probably). |
@danielzsh Should be working now! |
thank you so much! really appreciate the mdsvex project :) |
The issue of the build bombing out appeared to be related to the version of the Rollup plugins used. Upgrading them fixed it. I've sent a new PR for the SvelteKit upgrade here: #563. Hopefully it can be merged again while it's in a working state |
Closes #317
https://mdsvex.pngwn.io/playground is currently broken. This fixes it