Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert site to SvelteKit #466

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Convert site to SvelteKit #466

merged 3 commits into from
Jan 21, 2024

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 4, 2022

Closes #317

https://mdsvex.pngwn.io/playground is currently broken. This fixes it

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: 6ebbbc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I’m just poking around and this makes sense to me FWIW :)

packages/site/package.json Outdated Show resolved Hide resolved
@danielzsh
Copy link

@pngwn are there any plans to merge this? it appears https://mdsvex.pngwn.io/playground is still broken.

@pngwn pngwn merged commit f8bb1bf into pngwn:master Jan 21, 2024
7 checks passed
@danielzsh
Copy link

Hm, it appears the playground still doesn't work...I guess this PR was addressing a different issue with the playground then :(

@pngwn
Copy link
Owner

pngwn commented Jan 22, 2024

No, this PR just didn't work.

@pngwn
Copy link
Owner

pngwn commented Jan 22, 2024

I'll fix.

@benmccann benmccann deleted the kit branch January 22, 2024 00:39
@benmccann
Copy link
Contributor Author

What was it that didn't work about the PR? I didn't notice anything in my own testing

@pngwn
Copy link
Owner

pngwn commented Jan 22, 2024

just exploded in the build, some weird module issue not sure yet. I'm gonna debug it tomorrow but I'm just gonna fix the playground issue first.

@pngwn
Copy link
Owner

pngwn commented Jan 22, 2024

I'm not even convinced that the module that was causing issues is even used, so i find it a bit weird tbh. But it was something to do with a cjs -> esm transformation somewhere (a problem that will haunt me till i die probably).

@pngwn
Copy link
Owner

pngwn commented Jan 22, 2024

@danielzsh Should be working now!

@danielzsh
Copy link

thank you so much! really appreciate the mdsvex project :)

@benmccann
Copy link
Contributor Author

The issue of the build bombing out appeared to be related to the version of the Rollup plugins used. Upgrading them fixed it. I've sent a new PR for the SvelteKit upgrade here: #563. Hopefully it can be merged again while it's in a working state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate site to SvelteKit
5 participants