Merge decomposition-algorithms with decompose_fori_loop #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents (this time for tri-diagonalisation)
…ot as a namedtuple) and make decompose_fori_loop private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title states.
This PR breaks backwards compatibility (but the next release is already breaking, so we might as well make the remaining breaking changes now).
Why?
Because both decompose_fori_loop, as well as the Lanczos-decomposition algorithms, have always been closely tied together (one did not work without the other). Now, this is more clear because only one of them is public.
As a side result, matrix-decomposition algorithms now implement parametrised matrix-vector products, and the matrix-decomposition algorithms share an output type with Hutchinson-, Lanczos-, and Chebyshev-style methods.