Internal: Move error-scaling (by the error contraction rate) outside of the controller implementations #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controllers are functions of the error, but not the error estimate itself; rather, the error is normalised by atol, rtol, and a current estimate and scaled by the error contraction rate.
This PR applies the error-contraction-rate scaling inside adaptive.rejection_loop() instead of controller.apply(), which reduces the number of arguments of the latter. It also fits better with error normalisation, which already happens in the adaptive solver.
This change is internal. Users are not affected (unless they use the controllers for something non-probdiffeq related, which I find very unlikely)