Skip to content

Commit

Permalink
Fix: add missing test cases for ProbNum25, addressing comments by `pn…
Browse files Browse the repository at this point in the history
…kraemer`
  • Loading branch information
Philipp Hennig committed Oct 17, 2024
1 parent 201357f commit bc19b9f
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 5 deletions.
5 changes: 5 additions & 0 deletions tests/test_rc_params_cases/case_bundles.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ def case_bundles_tmlr2023():
return bundles.tmlr2023(nrows=2, ncols=2, family="serif")


@pytest_cases.parametrize(column=["full", "half"])
def case_bundles_probnum2025(column):
return bundles.probnum2025(column=column, nrows=1, ncols=1, family="sans-serif")


def case_bundles_beamer_moml():
return bundles.beamer_moml(rel_width=0.9, rel_height=0.9)

Expand Down
8 changes: 8 additions & 0 deletions tests/test_rc_params_cases/case_figsizes.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,13 @@ def case_figsizes_jmlr2001():
return figsizes.jmlr2001(nrows=2, ncols=3, height_to_width_ratio=1.0)


def case_figsizes_probnum2025_full():
return figsizes.probnum2025_full(nrows=2, ncols=3, height_to_width_ratio=1.0)


def case_figsizes_probnum2025_half():
return figsizes.probnum2025_half(nrows=2, ncols=3, height_to_width_ratio=1.0)


def case_beamer_169():
return figsizes.beamer_169(rel_width=0.5, rel_height=0.1)
4 changes: 4 additions & 0 deletions tests/test_rc_params_cases/case_fonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,7 @@ def case_fonts_cvpr2024_tex_default():

def case_fonts_cvpr2024_tex_custom():
return fonts.cvpr2024_tex(family="serif")


def case_fonts_probnum2025_tex_default():
return fonts.probnum2025_tex()
4 changes: 4 additions & 0 deletions tests/test_rc_params_cases/case_fontsizes.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,9 @@ def case_fontsizes_jmlr2001():
return fontsizes.jmlr2001()


def case_fontsizes_probnum2025():
return fontsizes.probnum2025()


def case_fontsizes_beamer():
return fontsizes.beamer()
2 changes: 1 addition & 1 deletion tueplots/bundles.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def iclr2024(*, usetex=True, rel_width=1.0, nrows=1, ncols=1, family="serif"):
return {**font_config, **size, **fontsize_config}


def probnum2025(*, column="half", nrows=1, ncols=1, family="serif"):
def probnum2025(*, column="half", nrows=1, ncols=1, family="sans-serif"):
"""ProbNum 2025 bundle."""
if column == "half":
size = figsizes.probnum2025_half(nrows=nrows, ncols=ncols)
Expand Down
8 changes: 4 additions & 4 deletions tueplots/figsizes.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,8 @@ def probnum2025_half(
pad_inches=_PAD_INCHES,
):
"""Single-column (half-width) figures for ProbNum 2025."""
figsize = _from_base_in(
base_width_in=3.333,
figsize = _from_base_pt(
base_width_pt=240,
rel_width=1.0,
height_to_width_ratio=height_to_width_ratio,
nrows=nrows,
Expand All @@ -362,8 +362,8 @@ def probnum2025_full(
pad_inches=_PAD_INCHES,
):
"""Full-page (full-width) figures for ProbNum 2025."""
figsize = _from_base_in(
base_width_in=6.944,
figsize = _from_base_pt(
base_width_pt=500,
rel_width=rel_width,
height_to_width_ratio=height_to_width_ratio,
nrows=nrows,
Expand Down

0 comments on commit bc19b9f

Please sign in to comment.