Adapt "docs" CI action for Python 3.12 #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venvs created with Python 3.12 no longer include `setuptools`, so we need to install it manually.
|
Hi! Thanks so much for this PR :) It seems that installing setuptools was not the easy fix we thought it was. Therefore, in #135, I set the doc-build version to 3.9 (and bumped the readthedocs version to 3.9 to match this), because these two version should coincide anyway. Now it all works again. In a separate PR, all python versions can then be bumped appropriately. But for now, let's close this PR and merge your ICML contribution! 👍 Thanks a lot @timweiland ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in PR #133.
venvs created with Python 3.12 no longer include
setuptools, so we need to install it manually.Let's see if this fixes the CI :)