Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The flow lets you calculate the last working day of the month #102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sudeepghatak
Copy link

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

(DELETE THIS PARAGRAPH AFTER READING)

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

Submitter Guidance (DELETE AFTER READING)

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Pull requests that do not follow this template will be automatically rejected.

Please target your PR to main branch.

Remember that this repository is maintained by community members who volunteer their time to help. Be courteous and patient.

(DELETE THIS SECTION AFTER READING)

@Katerina-Chernevskaya
Copy link
Contributor

Hello @sudeepghatak ,

Thank you for your submission! We value your time and contribution.
To move forward with the review and merging of your pull request, we kindly request that you update your PR in accordance with the Contribution Guidelines. Please ensure that the README file is updated following the provided template, and add the source code as instructed.

Please make sure you create your branch in the fork and update it to reflect the latest changes from the main branch.

Thank you!

Regards,
Katerina Chernevskaya

@Katerina-Chernevskaya Katerina-Chernevskaya added the Needs Attention Something needs to be fixed with the PR before merging label Jul 31, 2024
@sudeepghatak
Copy link
Author

Hi @Katerina-Chernevskaya , I have updated the README file and solution as instructed. Do I need to make another pull request?

@Katerina-Chernevskaya
Copy link
Contributor

Hi @sudeepghatak ,

The issue with solution compilation is still reproduced. Could you please check that you used pac solution clone as mentioned in the guideline? For more detailed instructions how to prepare the sourcecode folder please refer to this link: https://github.com/pnp/powerapps-samples/wiki/How-to-submit-a-Power-App-sample#clone-the-solution.

If you have any questions regarding the source code preparation - please feel free to ping me.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants