Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the sample folder to power-365-crm #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Power365initiatives
Copy link

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • [ X] New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

@Power365initiatives
Copy link
Author

Hi @Katerina-Chernevskaya

I've changed the name of the sample folder from Power365CRM to power-365-crm, I saw that all the files are in place including the files for both custom pages that are in the sales solution.

@Power365initiatives
Copy link
Author

Power365initiatives commented Mar 15, 2024

this is related with Pull request #78, I've also followed the guidelines to add a contribution, could it be that I am missing a cli command that I need to execute?

@Katerina-Chernevskaya
Copy link
Contributor

Hi @Power365initiatives,

Thank you for updating! I tried to generate the solution from the source code for the Sales Solution and dot the error again:
image
I used your new branch https://github.com/Power365initiatives/powerplatform-samples/tree/Power-365-crm.
Please check again and make sure that all required components are in place. Also please remove one of the PR and keep just one for the solution.

Thank you!

Regards,
Katerina Ch.

@Katerina-Chernevskaya Katerina-Chernevskaya added the Needs Attention Something needs to be fixed with the PR before merging label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants