Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and enhancements #97

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bug fix and enhancements #97

wants to merge 4 commits into from

Conversation

sudhirke
Copy link

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

What's in this Pull Request?

Update to correct status when "Save" button is clicked on My Timesheet screen.
Updated manager details when saved timesheet is submitted from "My timesheet" screen.

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

Status should remain 1 - Pending whenever user makes updates to any of their timesheet.  Updated status value on Save button click.
Screen: My Timesheets
When records are submitted with status "Submitted for approval",  manager information should be updated with current user's manager.  Instead it was being submitted as current user with status "Submitted for Approval"
Update TimeCardContinue.fx.yaml
Update TimeCardContinue.fx.yaml
@sudhirke
Copy link
Author

Contains fixes for Timecard functionality where manager information was not populated on the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager details are not updated when saving / submitting from My Timesheet's screen
1 participant