feat: check pm with a version number #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this look good ?? Let me know if there are any changes. |
zkochan
reviewed
Feb 16, 2022
| if (wantedPM !== 'npm' && wantedPM !== 'pnpm' && wantedPM !== 'yarn') { | ||
| console.log(`"${wantedPM}" is not a valid package manager. Available package managers are: npm, pnpm, or yarn.`) | ||
| process.exit(1) | ||
| } | ||
| const usedPM = whichPMRuns() | ||
| if (usedPM && usedPM.name !== wantedPM) { | ||
| if (usedPM && usedPM.name !== wantedPM && usedPM.version !== wantedVersion) { |
There was a problem hiding this comment.
what about when the version is not specified? In that case it shouldn't be checked, right?
Suggested change
| if (usedPM && usedPM.name !== wantedPM && usedPM.version !== wantedVersion) { | |
| if (usedPM && (usedPM.name !== wantedPM || wantedVersion && usedPM.version !== wantedVersion)) { |
|
Not sure if we need this feature as I know that pnpm, for instance, may verify its own version, using the engines field in |
|
@zkochan Though the engine field can verify its own version, the |
|
+1
Exactly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.