Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused error variant #215

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

KSXGitHub
Copy link
Contributor

No description provided.

@KSXGitHub KSXGitHub requested review from zkochan and anonrig November 22, 2023 19:17
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c62a631) 92.65% compared to head (3f136ef) 92.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   92.65%   92.62%   -0.04%     
==========================================
  Files          57       57              
  Lines        2847     2847              
==========================================
- Hits         2638     2637       -1     
- Misses        209      210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01      6.8±0.46ms   637.6 KB/sec    1.00      6.7±0.32ms   643.5 KB/sec

Copy link

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 128.9 ± 9.4 116.3 148.2 1.01 ± 0.12
pacquet@main 127.1 ± 11.7 109.1 146.4 1.00
BENCHMARK_REPORT.json
{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.12886527408666668,
      "stddev": 0.009390801958232876,
      "median": 0.12725571322,
      "user": 0.05929497333333333,
      "system": 0.20187049999999998,
      "min": 0.11626900122,
      "max": 0.14821123522000001,
      "times": [
        0.13326030922,
        0.13528109322,
        0.12213969722000001,
        0.12725571322,
        0.12304037622000001,
        0.11626900122,
        0.11957694822,
        0.14821123522000001,
        0.12799842222000002,
        0.13870057222,
        0.12209655722,
        0.13570431622,
        0.11956043922000001,
        0.14136545122,
        0.12251897922
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.12706121097,
      "stddev": 0.01171972575629837,
      "median": 0.12513366872,
      "user": 0.05461075249999999,
      "system": 0.2075073625,
      "min": 0.10907753822,
      "max": 0.14637111622,
      "times": [
        0.12793721822,
        0.13581961022,
        0.12089280922000001,
        0.14565912022,
        0.10907753822,
        0.12783631422,
        0.11465643822,
        0.11323994322,
        0.12059301722,
        0.14637111622,
        0.14399747622,
        0.11942810522000001,
        0.12871012522,
        0.12243102322,
        0.11969281922000001,
        0.13663670122000002
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    }
  ]
}

@zkochan zkochan merged commit 96ab1de into main Nov 28, 2023
12 of 13 checks passed
@zkochan zkochan deleted the refactor-remove-unused-error-variant branch November 28, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants