feat: add http caching to reqwest #75
Conversation
| clap = { workspace = true } | ||
| futures-util = { workspace = true } | ||
| rayon = { workspace = true } | ||
| reflink-copy = { workspace = true } | ||
| reqwest = { workspace = true } | ||
| node-semver = { workspace = true } | ||
| serde = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| tokio = { workspace = true } | ||
| clap = { workspace = true } | ||
| http-cache-reqwest = { workspace = true } | ||
| futures-util = { workspace = true } | ||
| moka = { workspace = true } | ||
| rayon = { workspace = true } | ||
| reflink-copy = { workspace = true } | ||
| reqwest = { workspace = true } | ||
| reqwest-middleware = { workspace = true } | ||
| node-semver = { workspace = true } | ||
| serde = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| tokio = { workspace = true } |
There was a problem hiding this comment.
See? This is the huge diff that I talked about.
|
Anyway, I will review this later. Maybe tomorrow, or maybe next week. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 24 24
Lines 1239 1253 +14
=======================================
+ Hits 1058 1070 +12
- Misses 181 183 +2
☔ View full report in Codecov by Sentry. |
Benchmark ResultsLinux |
|
I will make a prediction: This will likely be rendered irrelevant once a proper hashmap-based caching mechanism is implemented. |
I think we shouldn't follow this pattern, and start working on the hashmap-based caching mechanism. |
|
@anonrig Since we have merged hashmap based caching mechanism and full parallelization, you can now do a benchmark (in |
|
It looks like we've just added mem-cache to the tarball download, should we add a cache for fetching the package from the registry as well? Whether we implement mem-cache or not, perhaps http_caching stored on disk still has some value? |
|
@await-ovo Currently, all network requests in |
before
after