Make it branch agnostic #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phahulin
reviewed
Jan 24, 2018
| @@ -33,7 +34,7 @@ function findKeysCallBack(web3, miningKey, payoutKey) { | |||
| } | |||
|
|
|||
| function retrievePayoutKey(miningKey, cb) { | |||
| var contractAddress = config.Ethereum.contracts.KeysManager.addr; | |||
| var contractAddress = config.Ethereum.contracts.KeysManager[network].addr; | |||
There was a problem hiding this comment.
Maybe pass contractAddress directly as env variable here? Or, still better
- make a .json file in corresponding branch of spec repo with all contract addresses and their abis
- in this repository add this file to .gitignore
- use this file's data in script
- in playbook - download this file from spec repo during installation
There was a problem hiding this comment.
👍
@vbaranov what do you think?
There was a problem hiding this comment.
@rstormsf I made PR to your branch rstormsf#1 with the change: ABI and contract address from single endpoint: chain-spec repo. If you and @phahulin are ok, let's merge it and then merge current PR. Or let me know if anything wrong.
There was a problem hiding this comment.
rstormsf#1 is closed due to poanetwork/poa-scripts-moc#21 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires changes in ansible deployment scripts:
https://github.com/poanetwork/deployment-playbooks/search?utf8=%E2%9C%93&q=SCRIPTS_VALIDATOR_BRANCH&type=
If we agree on this approach, lets merge this PR and then make a change in deployment playbooks