Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBT based code generator (#22) #25

Merged
merged 36 commits into from
May 5, 2013
Merged

Conversation

guersam
Copy link
Contributor

@guersam guersam commented May 4, 2013

Eventually I managed to compile it!

Changes are as below:

  • When you compile using SBT, it automatically generate the source code from templates. If you just want generated sources, scaloid:generate task will do this.
  • I wrote event listener extractor based on your implementation. Some listeners are added as a result but they have potential issues mentioned at Possible issue with multiple short listeners #24.
  • removed setter helper because it's rarely used and hard to convert to StringTemplate. Maybe we need something more powerful to replace this.
  • Included property setters having nameClashed. I'll remove them if it's excluded by intention.
  • Some hacks are used for the interoperability between Scala and Java. I tried to keep readability of the source code, but additional discussion or comment might be needed.
  • Moved package object file to inside of package directory.

pocorall added a commit that referenced this pull request May 5, 2013
@pocorall pocorall merged commit a3ffa2a into pocorall:master May 5, 2013
@pocorall
Copy link
Owner

pocorall commented May 5, 2013

GREAT! Thank you for this awesome contribution.
I will review the issues following this pull within two or three days.

@guersam
Copy link
Contributor Author

guersam commented May 5, 2013

Happy to be a committer of Scaloid :)
I'll keep #22 open until your review and look for other enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants