HMS-2694 feat: Host conf token MVP #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
hms-2694-minimal-token
branch
from
edbc155 to
c8d044a
Compare
Implement minimal host conf token and signing JWK. A private ECDSA key is genenerated from a hard-coded seed and the JWK is stored in memory. In the future, the ECDSA key will be generated from a random source and the JWK stored in the database. The `GET /signing_keys` endpoint returns the public JWK. The `POST /host-conf` endpoint now returns a signed token. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
hms-2694-minimal-token
branch
from
c8d044a to
2cfac4f
Compare
|
Diff looks good. I'm going to do some testing before I merge it. |
|
It works. There are some things that need addressing but not in this diff. Better to follow-up with subsequent PRs and keep this already-big PR from growing more. So, I am merging it. Thanks! |
frasertweedale
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement minimal host conf token and signing JWK.
A private ECDSA key is genenerated from a hard-coded seed and the JWK is
stored in memory. In the future, the ECDSA key will be generated from a
random source and the JWK stored in the database.
The
GET /signing_keysendpoint returns the public JWK.The
POST /host-confendpoint now returns a signed token.Signed-off-by: Christian Heimes [email protected]